feat: add progress dialog to Questrade single account sync#67
Merged
Conversation
- Show step-by-step progress dialog (balance, positions, orders, activity) for single account sync, matching the all-accounts sync experience - Mirrors Wealthsimple's uploadSingleAccountWithProgress pattern - Replace processAccountBalanceHistory with direct syncAccountToMonarch call - Add cancel support with summary display on completion/error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a step-by-step progress dialog to the Questrade single account sync button, matching the experience of the all-accounts sync and the Wealthsimple integration.
Changes
processAccountBalanceHistorycall with directsyncService.syncAccountToMonarchcall passing the progress dialoguploadSingleAccountWithProgressapproachBefore
Single account sync ran silently with no visual progress feedback.
After
Single account sync shows the same detailed progress dialog as the all-accounts sync: